introduce property_checker_resultt
#651
Merged
+66
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
property_checker_resultt
branch
3 times, most recently
from
90c7354 to
c3e78b3
Compare
tautschnig
reviewed
Aug 30, 2024
src/ebmc/property_checker.h
Outdated
| @@ -12,6 +12,13 @@ Author: Daniel Kroening, [email protected] | |||
| #include "ebmc_properties.h" | |||
| #include "transition_system.h" | |||
|
|
|||
| enum class property_checker_resultt | |||
| { | |||
| REPORT_RESULT, | |||
There was a problem hiding this comment.
I am struggling to understand what this one is about? Or, rather, why is "SUCCESS" not a "result?"
There was a problem hiding this comment.
It's not a verification result -- rename REPORT_RESULT -> REPORT_VERIFICATION_RESULT?
There was a problem hiding this comment.
Or simply VERIFICATION_RESULT?
There was a problem hiding this comment.
VERIFICATION_RESULT works for me.
|
Also, is there a case for re-using |
It will move into this direction; but there simply aren't any goto programs. |
This introduces a type for the result from an engine, as a replacement for 'int'.
kroening
force-pushed
the
property_checker_resultt
branch
from
c3e78b3 to
7a255f6
Compare
tautschnig
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a type for the result from an engine, as a replacement for
int.